Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Elution peak detection: rare segfault if no features were detected (e.g., in blanks) #5652

Merged
merged 1 commit into from Nov 12, 2021

Conversation

timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Nov 12, 2021

Description

  • Elution model fit now throws if no features provided (before segfault in median calculation)
  • FFMetaboIdent now only calls fitting if at least one feature was found

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg changed the title fix rare exception if no features were detected (e.g., in blanks) fix rare segfault if no features were detected (e.g., in blanks) Nov 12, 2021
@timosachsenberg timosachsenberg changed the title fix rare segfault if no features were detected (e.g., in blanks) [fix] Elution peak detection: rare segfault if no features were detected (e.g., in blanks) Nov 12, 2021
@timosachsenberg timosachsenberg merged commit 646d493 into develop Nov 12, 2021
@timosachsenberg timosachsenberg deleted the feature/fix_ffmid branch November 12, 2021 09:33
@hroest
Copy link
Contributor

hroest commented Nov 12, 2021

@timosachsenberg add a unit test?

@timosachsenberg
Copy link
Contributor Author

k will add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyOpenMS binder FeatureFinderAlgorithmMetaboIdent() param issues
3 participants