Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pep evidences df #5656

Merged
merged 5 commits into from Nov 16, 2021

Conversation

axelwalter
Copy link
Collaborator

@axelwalter axelwalter commented Nov 15, 2021

Description

Added the export of peptide evidences for the best peptide hit in peptide_identifications_to_df(). New columns for accession, start and end position of peptide evidences. They are comma separated similar to mzTab.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg merged commit 75dee2b into OpenMS:develop Nov 16, 2021
@timosachsenberg
Copy link
Contributor

Thanks! looks good. I think we can now think about an extension to the readthedocs page how to use the dfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants