Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Decoding ontology in PeptideIdentification df conversion #5659

Merged
merged 8 commits into from Nov 18, 2021

Conversation

axelwalter
Copy link
Collaborator

@axelwalter axelwalter commented Nov 17, 2021

Function peptide_identifications_to_df() crashed when decode_ontology was set False. Because meta values were not decoded to strings, checking meta values in the CV failed when calling startswith().

Please include a summary of the change and which issue is fixed.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg
Copy link
Contributor

there seem to be a merge conflict.
can you add a simple test with / without decoding ontology?

@timosachsenberg
Copy link
Contributor

Would be good to have a test that rötestes the ontology decoding. Will merge this as a bugfix

@timosachsenberg timosachsenberg merged commit 7ae58db into OpenMS:develop Nov 18, 2021
@axelwalter axelwalter deleted the feature/pep-evidences-df branch March 17, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants