Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in TOPPView #5674

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Fix race condition in TOPPView #5674

merged 3 commits into from
Nov 24, 2021

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented Nov 24, 2021 •
edited

Description

fixes a race condition when multiple threads call newFile() and the reference gets invalidated (happened in TOPPView, when requesting a temporary file for INI's)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg merged commit 12ec655 into OpenMS:develop Nov 24, 2021
@timosachsenberg
Copy link
Contributor

there seems to be an issue: http://cdash.openms.de/viewBuildError.php?buildid=210499 I can take a quick look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timosachsenberg timosachsenberg timosachsenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cbielow @timosachsenberg