Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy performance-inefficient-vector/string-operation #5676

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

timosachsenberg
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg changed the title performance-inefficient-vector/string-operation clang-tidy performance-inefficient-vector/string-operation Nov 24, 2021
@timosachsenberg
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the performance-inefficient-vector-operation branch from 315a224 to 4a3e103 Compare November 24, 2021 21:24
@timosachsenberg timosachsenberg merged commit b391237 into develop Nov 25, 2021
@timosachsenberg timosachsenberg deleted the performance-inefficient-vector-operation branch November 25, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants