add rvalue reference

[timosachsenberg]

Description

Based on results from clang-tidy scan .

Checklist:

• Make sure that you are listed in the AUTHORS file
• Add relevant changes and new features to the CHANGELOG file
• I have commented my code, particularly in hard-to-understand areas
• New and existing unit tests pass locally with my changes
• Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

• http://cdash.openms.de/index.php?project=OpenMS and look for your PR. If you click in the column that lists the failed tests you will get detailed error messages.

Note:

• Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

[hroest]

also this

hits_.push_back(std::forward<PeptideHit>(hit));

should probably be

hits_.push_back(std::move(hit));

It works, but is somewhat unconvential in an non-templated environment: https://stackoverflow.com/questions/28828159/usage-of-stdforward-vs-stdmove. Alternatively we could capture both cases using a template

template <typename T> void PeptideIdentification::setHits(T&& hits)
{
  hits_ = std::forward<T>(hits);
}

but doesnt seem very much "OpenMS-like"

[timosachsenberg]

/rebase

[timosachsenberg]

tests pass now.

[cbielow]

could also be std::move(in)?
Not crucial though

[cbielow]

nice!