Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] added 3' phosphate gain for unspecific cleavage of nucleotides.… #5694

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

poshul
Copy link
Collaborator

@poshul poshul commented Dec 2, 2021

… This is consistant with AbouHaidar and Ivanov 1999.

Description

Previously unspecific cleavage of RNA resulted in the loss of the phosphate group at the cleavage site. Per https://www.degruyter.com/document/doi/10.1515/znc-1999-7-813/pdf it appears that the more common behavior is for the phosphate to stay on the 3' end of the "left" fragment.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

… This is consistant with AbouHaidar and Ivanov 1999
@poshul poshul marked this pull request as draft December 2, 2021 09:10
@poshul poshul marked this pull request as ready for review December 2, 2021 10:49
@poshul
Copy link
Collaborator Author

poshul commented Dec 2, 2021

Jenkins seems to be on the fritz. @jpfeuffer any idea why we are getting the following:
Error when uploading file: /home/jenkins/ws/openms/PR/bldtst/a9154670/build/Testing/20211202-1027/Test.xml Error message was: Operation too slow. Less than 1 bytes/sec transferred the last 120 seconds Problems when submitting via HTTP

@timosachsenberg timosachsenberg merged commit e03d584 into OpenMS:develop Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants