Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add python compatible get precursor spectrum #5704

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Dec 14, 2021

Description

Add helper for pyopenms to retrieve the index of the precursor spectrum

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg
Copy link
Contributor Author

rebuild jenkins

@timosachsenberg
Copy link
Contributor Author

tests passed

Copy link
Contributor

@oliveralka oliveralka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO Looks good!

@axelwalter
Copy link
Collaborator

very useful, thanks!

@timosachsenberg timosachsenberg merged commit 6005e49 into develop Dec 15, 2021
@timosachsenberg timosachsenberg deleted the feature/pc_spectrum_python branch December 15, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants