-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer refactor: StatisticsDialog #5713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame__ == '__main__':`. Avoids infinite recursion for spawning new processes
currently our pyopenms build will include any CPP it finds, even its it not in the build system... weird...
- cleanup of LayerStatistics (separate model from view) - visualization improvements (show ints as ints, not as doubles; add subheaders for different data sources (meta vs. dataarrays vs. core)
…_refactor # Conflicts: # src/openms_gui/include/OpenMS/VISUAL/LayerDataBase.h # src/openms_gui/include/OpenMS/VISUAL/LayerDataChrom.h # src/openms_gui/include/OpenMS/VISUAL/LayerDataConsensus.h # src/openms_gui/include/OpenMS/VISUAL/LayerDataFeature.h # src/openms_gui/include/OpenMS/VISUAL/LayerDataIdent.h
test pass (even though status says otherwise). Any comments? |
timosachsenberg
approved these changes
Dec 20, 2021
timosachsenberg
approved these changes
Dec 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary reason for creating the PR was:
OpenMS/src/openms_gui/source/VISUAL/DIALOGS/LayerStatisticsDialog.cpp
Line 59 in 5ebaf1d
However, this required in turn to:
And while at it ...
Before:
After:
How can I get additional information on failed tests during CI:
If your PR is failing you can check out
Note:
Advanced commands (admins / reviewer only):