Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer refactor: StatisticsDialog #5713

Merged
merged 16 commits into from
Dec 21, 2021
Merged

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented Dec 20, 2021

Description

The primary reason for creating the PR was:

However, this required in turn to:

  • cleanup of LayerStatistics (separate model from view)

And while at it ...

  • visualization improvements (show ints as ints, not as doubles; add subheaders for different data sources (meta vs. dataarrays vs. core)

Before:
image

After:
image

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

Advanced commands (admins / reviewer only):

  • /rebase will try to rebase the PR on the current develop branch.
  • /reformat (experimental) applies the clang-format style changes as additional commit
  • setting the label NoJenkins will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)

…ame__ == '__main__':`. Avoids infinite recursion for spawning new processes
currently our pyopenms build will include any CPP it finds, even its it not in the build system... weird...
- cleanup of LayerStatistics (separate model from view)
- visualization improvements (show ints as ints, not as doubles; add subheaders for different data sources (meta vs. dataarrays vs. core)
…_refactor

# Conflicts:
#	src/openms_gui/include/OpenMS/VISUAL/LayerDataBase.h
#	src/openms_gui/include/OpenMS/VISUAL/LayerDataChrom.h
#	src/openms_gui/include/OpenMS/VISUAL/LayerDataConsensus.h
#	src/openms_gui/include/OpenMS/VISUAL/LayerDataFeature.h
#	src/openms_gui/include/OpenMS/VISUAL/LayerDataIdent.h
@cbielow
Copy link
Contributor Author

cbielow commented Dec 20, 2021

test pass (even though status says otherwise).

Any comments?

@timosachsenberg timosachsenberg merged commit d11477e into OpenMS:develop Dec 21, 2021
@cbielow cbielow mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants