Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make pyopenms cmake better. And log output better. #5730

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

jpfeuffer
Copy link
Contributor

Description

  • Uses official setup.py multithreading for C++ compilation
  • Adds multithreading for cython compilation
  • Splits cpp generation + cython compilation and C++ compilation and creates real dependencies on the outputs (no rebuilding)
  • Reduces log clutter (needs newer version of autowrap, PR in progress)

TODO:

  • Do for windows
  • Do the autowrap PR to better define log levels

@jpfeuffer jpfeuffer added the NoJenkins Skips Jenkins tests for PRs label Jan 6, 2022
@jpfeuffer jpfeuffer marked this pull request as ready for review January 10, 2022 16:43
@jpfeuffer
Copy link
Contributor Author

[100%] Built target OpenMS
Scanning dependencies of target compile_pxds
[100%] Creating C++ extension with autowrap and Cython
Build type is:  Release
Number of submodules:  8
Number of concurrent threads:  1
ADDED __str__ method to DataFilter
ADDED __str__ method to RANSACParam
ADDED __str__ method to AASequence
ADDED __str__ method to EmpiricalFormula
ADDED __str__ method to NASequence
ADDED __str__ method to DataValue
ADDED __str__ method to MZTrafoModel
ADDED __str__ method to MassDecomposition
Autowrap has wrapped 76 classes, 628 methods and 12 enums
Autowrap has wrapped 74 classes, 734 methods and 11 enums
Autowrap has wrapped 79 classes, 961 methods and 8 enums
Autowrap has wrapped 85 classes, 653 methods and 9 enums
Autowrap has wrapped 72 classes, 808 methods and 12 enums
Autowrap has wrapped 76 classes, 670 methods and 15 enums
Autowrap has wrapped 93 classes, 914 methods and 8 enums
Autowrap has wrapped 80 classes, 815 methods and 14 enums
Cython compile pyopenms/pyopenms_1.pyx
Cython compile pyopenms/pyopenms_2.pyx
Cython compile pyopenms/pyopenms_3.pyx
Cython compile pyopenms/pyopenms_4.pyx
Cython compile pyopenms/pyopenms_5.pyx
Cython compile pyopenms/pyopenms_6.pyx
Cython compile pyopenms/pyopenms_7.pyx
Cython compile pyopenms/pyopenms_8.pyx
Created all 8 pyopenms.cpps
[100%] Built target compile_pxds
Scanning dependencies of target pyopenms
[100%] Compiling and linking pyopenms C++ extension with the chosen C++ compiler
running build_ext
building 'pyopenms_1' extension

Copy link
Contributor

@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@jpfeuffer jpfeuffer merged commit 738747e into OpenMS:develop Jan 10, 2022
@jpfeuffer jpfeuffer deleted the feat/betterPyOmsBuild branch January 10, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NoJenkins Skips Jenkins tests for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants