Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOPPView Preferences Dialog refactor #5732

Merged
merged 6 commits into from
Jan 7, 2022

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented Jan 6, 2022

Description

Expose TSG parameters in TOPPView preferences and make parameter handling less manual.
Still, we should replace the whole TV Pref dialog with a ParamEditor at some point, because there are many points of failure ATM.
But this needs some more features in ParamEditor first, e.g. editing of ColorGradients.

also in this PR:
Some code renaming and documentation.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

Advanced commands (admins / reviewer only):

  • /rebase will try to rebase the PR on the current develop branch.
  • /reformat (experimental) applies the clang-format style changes as additional commit
  • setting the label NoJenkins will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)

@cbielow cbielow changed the title Layer refactor TOPPView Preferences Dialog refactor Jan 6, 2022
@timosachsenberg timosachsenberg merged commit d4ac008 into OpenMS:develop Jan 7, 2022
cbielow added a commit to cbielow/OpenMS that referenced this pull request Jan 7, 2022
@cbielow cbielow mentioned this pull request Jan 7, 2022
timosachsenberg pushed a commit that referenced this pull request Jan 7, 2022
* rename function to better describe its purpose

* [DOC, PARAM] improvements for TSGs parameters

* allow to retrieve validStrings for a Param

* restructure call to defaultsToParam_

* - replace TheoSpecGen parameter UI with a more generic ParamEditor and make use of automatic parameter copying
- support spectra alignment using PPM instead of Dalton

* fix bug in #5732 which causes crash due to missing meta information

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants