Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Complete target-based find modules and CMake-based pyopenms builds #5757

Merged
merged 45 commits into from
Feb 9, 2022

Conversation

jpfeuffer
Copy link
Contributor

Description

  • Adds imported targets for all find modules that are not yet available as an official CMake module
  • Use the targets to have transitive includes and lib dependencies
  • Switch pyopenms to a CMake-based build (all the code in setup.py is just there for backwards compatibility)
  • Add real export capabilities for people developing with OpenMS

With this, a completely separate pyopenms build could be achieved in the future, based on an installed OpeMS. We probably need to ship the PXDs, kind of like

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Jan 24, 2022

Seems like we build contrib with non-standard names. We might need to re-introduce the find modules and maintain them.
EDIT: Seems like the contrib share was missing for Eigen. And some CMake configuration in the find_package call should be enough.

@jpfeuffer
Copy link
Contributor Author

rebuild jenkins

@jpfeuffer
Copy link
Contributor Author

rebuild jenkins

@jpfeuffer
Copy link
Contributor Author

rebuild jenkins

@jpfeuffer
Copy link
Contributor Author

/rebase

@timosachsenberg
Copy link
Contributor

                   _   
                  | |  
  __ _  ___   __ _| |_ 
 / _` |/ _ \ / _` | __|
| (_| | (_) | (_| | |_ 
 \__, |\___/ \__,_|\__|
  __/ |                
 |___/                 

@jpfeuffer
Copy link
Contributor Author

Going to merge. Expect trouble in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants