Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove WM5 from headers #5797

Merged
merged 6 commits into from
Feb 9, 2022
Merged

remove WM5 from headers #5797

merged 6 commits into from
Feb 9, 2022

Conversation

timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Feb 8, 2022

Description

To prevent symbols being exported.
RegressionUtils.h was removed for same reasons (did not safe code anyways).
As well as the test which was not run anyways.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

Advanced commands (admins / reviewer only):

  • /rebase will try to rebase the PR on the current develop branch.
  • /reformat (experimental) applies the clang-format style changes as additional commit
  • setting the label NoJenkins will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)

timosachsenberg and others added 2 commits February 8, 2022 16:50
Co-authored-by: Julianus Pfeuffer <pfeuffer@informatik.uni-tuebingen.de>
@jpfeuffer
Copy link
Contributor

@timosachsenberg
Copy link
Contributor Author

https://stackoverflow.com/questions/60463014/cmath-error-on-macos-c17-call-to-abs-ambiguous please leave fabs

I thought this only holds for integral types and not for double. Are you sure this causes an error? Or is cmath missing?

@jpfeuffer
Copy link
Contributor

jpfeuffer commented Feb 8, 2022

Yes it's in Jenkins.
Abs only works for floats since c17 and apparently not in all versions of Apples libc++ (when both cmath and cstdlib are included or something like that)

@jpfeuffer
Copy link
Contributor

I think it has to be std::fabs

@jpfeuffer
Copy link
Contributor

Should be fine. Windows out of space.

@jpfeuffer jpfeuffer merged commit a5c7ba9 into develop Feb 9, 2022
@jpfeuffer jpfeuffer deleted the fix/WM5_export branch February 9, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants