Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gaussFilter's wrong ppm width #6830

Merged
merged 5 commits into from Apr 13, 2023
Merged

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented Apr 13, 2023

Description

ppm computation for the gaussian width was off by 1 order of magnitude
(using 10e-6 is not 10^-6 :) )

Checklist

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI

Click to expand If your PR is failing you can check out
  • The details of the action statuses at the end of the PR or the "Checks" tab.
  • http://cdash.openms.de/index.php?project=OpenMS and look for your PR. Use the "Show filters" capability on the top right to search for your PR number.
    If you click in the column that lists the failed tests you will get detailed error messages.

Advanced commands (admins / reviewer only)

Click to expand
  • /reformat (experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.
  • setting the label "NoJenkins" will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)
  • commenting with rebuild jenkins will retrigger Jenkins-based CI builds

⚠️ Note: Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg
Copy link
Contributor

sounds a bit rude ;)

checking (template <typename ConstIterT, typename IterT> bool filter(ConstIterT mz_in_start, ConstIterT mz_in_end, ConstIterT int_in_start, IterT mz_out, IterT int_out)) ... 
 -  line 91:TEST_REAL_SIMILAR(in,1.0): argument in does not have a floating point type!  Go fix your code!
 -  line 91:TEST_REAL_SIMILAR(in,1.0): argument in does not have a floating point type!  Go fix your code!
 -  line 91:TEST_REAL_SIMILAR(in,1.0): argument in does not have a floating point type!  Go fix your code!
 -  line 91:TEST_REAL_SIMILAR(in,1.0): argument in does not have a floating point type!  Go fix your code!
 -  line 91:TEST_REAL_SIMILAR(in,1.0): argument in does not have a floating point type!  Go fix your code!
: failed

@timosachsenberg timosachsenberg merged commit 1e08e9f into OpenMS:develop Apr 13, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants