Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMW-CS: Replaced most placeholder-icons to Lamoot's new OpenCS Icons. #1643

Closed
wants to merge 0 commits into from

Conversation

unelsson
Copy link
Collaborator

Changed many of the placeholder-icons to Lamoot's new icons. I don't know what was planned with these icons, but having icons for terrain edit, pathgrid-edit and instance moving should make using and testing easier.

@zinnschlag
Copy link
Contributor

Is that from the new set of icons that was worked on months back? Stylistically they don't seem to match what we have now in the editor. I am inclined to merge them anyway (mixed style is better than no icons). But lets wait a bit and see if someone else has some input to this topic.

@unelsson
Copy link
Collaborator Author

Yes, they are from here https://forum.openmw.org/download/file.php?id=1252 . I was also thinking that mixing styles is better than having no icons at all. Still the brush icons seem to be missing though.

@lysol90
Copy link
Contributor

lysol90 commented Mar 25, 2018

As I also said in the forum thread: Why not replace all icons with Lamoots icons? They are the most complete ones anyway. I like the old ones too, but they aren't a complete pack yet.

I said earlier that I thought we should wait to implement lamoots icons, but that was before he made almost all icons needed.

@zinnschlag
Copy link
Contributor

I am not up to date on the state of the new icon set. If we were going for a complete replacement, would we lose any icons we currently have? If the answer to this question is no, then we can as well go ahead with the replacement. If the answer is no, can we maybe ping the artist and ask if he could fill in the gaps?

@unelsson
Copy link
Collaborator Author

Testing the new icon set with all icons, there are some problems regarding filenames. It's a bit of work to update because filenames do not always match, however the new filenames have a systematic naming convention.
e.g. old: miscellaneous.png -> new: misc.png, old: eyeballdude.png -> new: camera-orbit.png

Some icons are missing. I noticed missing icons at cell view's lightning settings: sun, moon, lightbulb and instance-edit-mode centred cube, cube corner to corner and centred sphere.

@lysol90
Copy link
Contributor

lysol90 commented Mar 27, 2018

I sent a PM to Lamoot to check this github discussion if he felt like helping out.

@Lamoot
Copy link

Lamoot commented Mar 27, 2018

Heya all, great to see this being tackled.
(got the message by lysol)

Let me know which icons are still missing and I'll work on them. Mind you I'm a tad busy this week, but I'll try to produce them in a timely manner, next week most likely.

@unelsson
Copy link
Collaborator Author

unelsson commented Apr 2, 2018

Missing icons:
sun, moon, lightbulb - these signify the lightmode used in the world view
cube, cube corner to corner and cube centred sphere - these signify the selection mode used in instance editing, but I don't really know what these mean.
brush-point, brush-square, brush-circle, brush-custom - these signify the brush used in terrain texture editing (also land editing?)

@unelsson
Copy link
Collaborator Author

unelsson commented Apr 2, 2018

I messed my github master repository, so when updating that, this was accidentally closed. Anyway, I think I'll make a new pull request with all icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants