Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force quick load to use the last quicksave instead of any last save #1683

Closed
wants to merge 1 commit into from

Conversation

akortunov
Copy link
Collaborator

Fixes bug #4394.

Just search for the first save with the "Quicksave" desctiption for current character and load it. If there are no quick saves, do not load anything.

@kcat
Copy link
Contributor

kcat commented Apr 18, 2018

Is there a reason to do this? If the last save I made was a hard save (either because something important happened or because I stopped playing then started again), if I Quickload I'd expect the latest save to be loaded, not necessarily the latest quicksave which may have been farther back.

@Capostrophic
Copy link
Collaborator

Well, Morrowind and other Bethesda games quickload behavior is to load the quicksave, and since it's a reference point OpenMW should follow...

@kcat
Copy link
Contributor

kcat commented Apr 18, 2018

When it comes to gameplay and general presentation, sure. But OpenMW does make the odd quality-of-life improvement (see the alchemy window, or options menu). If having Quickload load the last save improves the user experience, why purposely change it to make it a worse experience?

@Capostrophic
Copy link
Collaborator

Capostrophic commented Apr 18, 2018

The user that reported this to akortunov was displeased with the current behavior. Such controversial divergencies should still be kept to a minimum - so if Morrowind behavior is followed instead, we are not to blame.

@kcat
Copy link
Contributor

kcat commented Apr 18, 2018

But it would still be on us to fix it, since this behavior isn't moddable. "Be like vanilla" isn't a statement to follow blindly, especially for non-gameplay aspects; it prevents all QoL improvements (big and small) and stops progress since anything that's not vanilla should be inherently rejected. The altered alchemy window, being able to type in amounts when selecting multiple of something or bartering, dropping multiple potions/ingredients onto your character when dragging a stack, windows going transparent when dragging an item to allow placing behind them, etc... these are all divergences from vanilla of varying magnitude, but remain because they improve the user experience without altering gameplay (much).

There needs to be a justification for the decision. The original bug report just said it's different and should be changed, I gave a reason why the current behavior is preferable. If there is to be a (non-gameplay) change from the current implementation, there should be a better reason than "just because", IMO. Is there a problem with the current behavior? Is the new behavior the actual standard most other games follow? Is the new behavior more widely favored among the player-base?

@akortunov
Copy link
Collaborator Author

akortunov commented Apr 19, 2018

I gave a reason why the current behavior is preferable.

Hmm... Where? This is hardly a QoL improvement, there are just two different approaches for quick saves. One games use first one, other games - last.

Is the new behavior the actual standard most other games follow? Is the new behavior more widely favored among the player-base?

Well, we can also ask these questions about current behaviour.
What we can do here:

  1. Check how quick save behaves in Bethesda's games
  2. Make changes optional (with vanilla behaviour by default).

@kcat
Copy link
Contributor

kcat commented Apr 19, 2018

Hmm... Where?

"If the last save I made was a hard save (either because something important happened or because I stopped playing then started again), if I Quickload I'd expect the latest save to be loaded, not necessarily the latest quicksave which may have been farther back."

A quickload is just that: load quickly. Same as a quicksave is save quickly. It's not its own separate system, it's just quick access to the existing system (you can manually load a quick save, so why not quickly load a manual save if it's the latest one)? If I have to remember if the last save I made was with the quicksave function or was manually made, that unnecessarily complicates the system and slows it down (as I'll fallback to the manual load menu just to be sure).

@Capostrophic
Copy link
Collaborator

Check how quick save behaves in Bethesda's games

It's behavior is consistent across the games. Even Skyrim and Fallout load the quicksave when the quickload button is pressed.

@ghost
Copy link

ghost commented Apr 19, 2018

Aside from kcat's argument which I agree with, changing the behavior now would be disruptive in that openmw users have to get used to the change. Wouldn't be surprised if someone would then report another bug on that.
The fact that it took years for anyone to notice the difference to bethesda and report the bug means that either no one noticed, no one cared or they actually prefer the new behavior.
If you want to change my mind on this, I suggest to make a user poll.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants