Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSG 3.6 binaries to CI script #1715

Closed
wants to merge 12 commits into from
Closed

Conversation

ananace
Copy link
Member

@ananace ananace commented May 20, 2018

Will have to drop Visual Studio 2013 support for this, don't have the ability to build up new 2013 binaries for 3.6.

Because of this, #1714 is probably going to be required to switch the CI from VS2013 + VS2015 to VS2015 + VS2017

@ananace ananace mentioned this pull request May 20, 2018
71 tasks
@ananace
Copy link
Member Author

ananace commented May 20, 2018

This should probably not be merged before it's been tested - and verified - by at least two people, seeing as OSG is a rather vital component of OpenMW.

@AnyOldName3
Copy link
Member

AnyOldName3 commented May 21, 2018

image

It no worky.

The file isn't in the archive, so obviously isn't in the extracted version of the archive, either. It was included in previous versions, though.

@ananace
Copy link
Member Author

ananace commented May 21, 2018

Right, the new OSG deps don't actually have any zlib DLL, the compression's statically linked.

Or, alternatively, I've just forgotten to copy them over into the OSG packages... oops.

@ananace
Copy link
Member Author

ananace commented May 21, 2018

I've uploaded new packages with the missing DLLs now

@AnyOldName3
Copy link
Member

I'm building it now. I guess it'll be about 40 minutes until I can tell you if it works.

@AnyOldName3
Copy link
Member

It built and runs.

@psi29a
Copy link
Member

psi29a commented May 22, 2018

@AnyOldName3 runs is good, did you run/fly around the landmass to see if there were any crashes with all the loading and unloading of cells (actors and statics)? That is a good stress test.

@AnyOldName3
Copy link
Member

I had one crash nearly immediately but can't replicate it with ten other runs doing the exact same thing.

@akortunov
Copy link
Collaborator

akortunov commented Jun 14, 2018

Not sure if it is a 3.6-specific, but sometimes I get the crash in SceneManager::createInstance().
Log complains about dynamic casts here.

@AnyOldName3
Copy link
Member

I don't understand how those dynamic casts could break. The results are being checked before being used.

@akortunov
Copy link
Collaborator

akortunov commented Jun 14, 2018

I don't understand how those dynamic casts could break.

I even more do not understand.
crash.log

OpenMW can crash randomly in very rare case upon save load or cell change.

This part is common in all cases:

#3 0x00007f80bfbcd743 in __dynamic_cast () from /usr/lib/gcc/x86_64-pc-linux-gnu/6.4.0/libstdc++.so.6
No symbol table info available.
#4 0x00005627b6bc6c88 in SceneUtil::CopyOp::operator()(osg::Node const*) const ()
No symbol table info available.
#5 0x00007f80c6539cbd in osg::Group::Group(osg::Group const&, osg::CopyOp const&) () from /usr/lib64/libosg.so.156
No symbol table info available.
#6 0x00005627b6bcd1f1 in SceneUtil::Skeleton::Skeleton(SceneUtil::Skeleton const&, osg::CopyOp const&) ()
No symbol table info available.
#7 0x00005627b6bcdf95 in SceneUtil::Skeleton::clone(osg::CopyOp const&) const ()
No symbol table info available.
#8 0x00005627b6ba1083 in osg::Node* osg::cloneosg::Node(osg::Node const*, osg::CopyOp const&) ()
No symbol table info available.
#9 0x00005627b6b9e257 in Resource::SceneManager::createInstance(osg::Node const*) ()

I had one crash nearly immediately

What crash.log says?

@akortunov
Copy link
Collaborator

akortunov commented Jul 31, 2018

OpenMW can crash randomly in very rare case upon save load or cell change.

I encountered this crash on 3.4.1 too, so it is not 3.6-specific. Weird.

@akortunov
Copy link
Collaborator

This PR is very outdated, and we are not going to use 3.6.x by default soon anyway because of its bug. So I see no point to keep this PR opened.

@akortunov akortunov closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants