New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSG 3.6 binaries to CI script #1715
Conversation
Sadly have to drop Visual Studio 2013 support for this
This should probably not be merged before it's been tested - and verified - by at least two people, seeing as OSG is a rather vital component of OpenMW. |
Right, the new OSG deps don't actually have any zlib DLL, the compression's statically linked. Or, alternatively, I've just forgotten to copy them over into the OSG packages... oops. |
I've uploaded new packages with the missing DLLs now |
I'm building it now. I guess it'll be about 40 minutes until I can tell you if it works. |
It built and runs. |
@AnyOldName3 runs is good, did you run/fly around the landmass to see if there were any crashes with all the loading and unloading of cells (actors and statics)? That is a good stress test. |
I had one crash nearly immediately but can't replicate it with ten other runs doing the exact same thing. |
Not sure if it is a 3.6-specific, but sometimes I get the crash in SceneManager::createInstance(). |
I don't understand how those dynamic casts could break. The results are being checked before being used. |
I even more do not understand. OpenMW can crash randomly in very rare case upon save load or cell change. This part is common in all cases:
What crash.log says? |
I encountered this crash on 3.4.1 too, so it is not 3.6-specific. Weird. |
This PR is very outdated, and we are not going to use 3.6.x by default soon anyway because of its bug. So I see no point to keep this PR opened. |
Will have to drop Visual Studio 2013 support for this, don't have the ability to build up new 2013 binaries for 3.6.
Because of this, #1714 is probably going to be required to switch the CI from VS2013 + VS2015 to VS2015 + VS2017