Resume game fully if the player was resurrected (bug #2626) #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AppVeyor msvc2015 is drunk again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 2626.
I've added a method to state manager which is called in the Resurrect function if the game has ended and sets the game state back to "running".
I'm not sure if this change would actually be useful, but currently even though openmw allows resurrecting the player and makes sure the player's health is not 0 after resurrection, the player is left off with a "broken" game. With this it returns to normal fully (including the menu, movement, music etc.), which looks somewhat better.
If we want the behavior of post-resurrected player game to be broken, then so be it.