[Regression] Handle case in the editor when actor's bodypart was not found #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinnschlag
reviewed
Nov 8, 2018
|
Looks like this may do it. Will get to it as soon as I can. Anyway, there is no reason for hurry. Not going to restart the RC build process over this one feature. |
|
Okay, that seems to fix the issue. Good catch! |
|
Merging. |
|
Probably we should restore actor's rendering in the 0.45 branch now. |
|
That's already been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the NPC's rendering feature in the editor.
Currently we do not fully handle a case, when a suitable bodypart was not found in the map (for example, a weapon bodypart, or a tail bodypart for humanoid races).
As a result, a bodypart ID string can contain a random data.
@zinnschlag, I suggest you to take a look at this PR ASAP - it may fix your issue with bad allocs.