Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump from C++11 to C++14 #2314

Merged
merged 2 commits into from Apr 12, 2019
Merged

bump from C++11 to C++14 #2314

merged 2 commits into from Apr 12, 2019

Conversation

psi29a
Copy link
Member

@psi29a psi29a commented Apr 9, 2019

give it a spin...

@psi29a psi29a changed the title bump from 11 to 14 bump from C++11 to C++14 Apr 9, 2019
@akortunov
Copy link
Collaborator

Just for reference - what the C++14 has for us?
Also, IIRC, MSVC2015 does not have the full C++14 support.

@psi29a
Copy link
Member Author

psi29a commented Apr 10, 2019

We'll find out as we start adding features. MSVC19 is also out or almost out? If we add support for that, then we drop MSVC2015.

std::make_unique

@akortunov
Copy link
Collaborator

MSVC19 is also out or almost out?

It is a Preview only. Before dropping 2015, we will need to make sure that 2019 builds OpenMW properly.

@psi29a
Copy link
Member Author

psi29a commented Apr 10, 2019

For now, we're OK with MSVC2015 so long as we don't use anything too esoteric. The moment people want to use things not supported by MSVC2015 is the moment we should look into moving on to MSVC2019.

@AnyOldName3
Copy link
Member

MSVC19 is also out or almost out?

It is a Preview only. Before dropping 2015, we will need to make sure that 2019 builds OpenMW properly.

I'm pretty sure the preview ended about a week ago and it's now been released properly.

I've only just transitioned from using 2015 to 2017 a few weeks ago and only have 2015 set up to use the same dependency versions as our releases, so if we can avoid dropping 2015 support for a bit, that might end up being useful.

It looks like the only missing features are a relaxation on what can be used as a constexpr and a minor change to how aggregates are initialised, so it might be a while before anything actually comes up that causes problems.

@psi29a
Copy link
Member Author

psi29a commented Apr 10, 2019

Well, I'm not going to do any more to this PR. So feel free to merge whenever someone feels like it.

@Capostrophic Capostrophic merged commit 5b8fc5a into master Apr 12, 2019
@Capostrophic Capostrophic deleted the stdc++14 branch April 12, 2019 14:34
@psi29a psi29a restored the stdc++14 branch April 12, 2019 14:53
@psi29a
Copy link
Member Author

psi29a commented Apr 12, 2019

Bwah hahahahahha!

@psi29a psi29a deleted the stdc++14 branch April 19, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants