comply with new OQN API #2676
Closed
comply with new OQN API #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnyOldName3
reviewed
Feb 14, 2020
| @@ -557,27 +558,33 @@ class Sun : public CelestialBody | |||
| { | |||
| osg::ref_ptr<osg::OcclusionQueryNode> oqn = new osg::OcclusionQueryNode; | |||
| oqn->setQueriesEnabled(true); | |||
|
|
|||
| #if OSG_VERSION_LESS_THAN(3,6,5) | |||
| osg::Geometry* queryGeom = oqn->getQueryGeometry(); | |||
There was a problem hiding this comment.
Always ref_ptr OSG stuff. Even if it's perfectly safe here, it's safer if other people start changing things later.
AnyOldName3
reviewed
Feb 14, 2020
Comment on lines
581
to
584
| // Hack to disable unwanted awful code inside OcclusionQueryNode::computeBound. | ||
| oqn->setComputeBoundingSphereCallback(new DummyComputeBoundCallback); | ||
| // Still need a proper bounding sphere. | ||
| oqn->setInitialBound(queryGeom->getBound()); |
There was a problem hiding this comment.
Are these definitely safe to remove?
There was a problem hiding this comment.
I just get back to what the code...sorry for previous noise
removing these line is more than safe, it gives better result: glow don't take few frame to display when sun enter frustum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.