Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New Movement Solver Fixes (Do not merge yet) #2937

Closed
wants to merge 65 commits into from

Conversation

wareya
Copy link
Contributor

@wareya wareya commented Jun 27, 2020

This is a manual rewrite of #1794 based on a much more recent version of master. See #1794 for a description of what changes this PR does.

This is the PR you want to use if you want to test how the movement solver fixes interact with double-precision bullet or threaded/async movement solving.

I intend to rebase this branch to logically split everything up into single stable commits or squash everything into a single commit so that it doesn't interfere with bisecting, so do not merge it yet.

These changes require double-precision Bullet. Otherwise interacting with certain objects becomes glitchy/unstable because single precision Bullet sucks.

@wareya
Copy link
Contributor Author

wareya commented Jun 27, 2020

As this branch switches to AABBs, it exhibits problems with the cantons in vivec and other incredibly large geometry when using single-precision bullet, but these problems essentially disappear when using double-precision bullet (I checked).

@psi29a
Copy link
Member

psi29a commented Jun 30, 2020

Double precision bullet is default for 64-bit on Debian and Ubuntu. I believe that MacOS already has that turned on in build deps. @nikolaykasyanov Can you double check?
@ananace Do we have DP enabled deps on windows for msvc 2015 and 2019?

@psi29a psi29a changed the title New Movement Solver Fixes (Do not merge yet) WIP: New Movement Solver Fixes (Do not merge yet) Jun 30, 2020
@psi29a
Copy link
Member

psi29a commented Jun 30, 2020

@wareya are we tracking this on the issue tracker? Such a massive undertaking deserves a ticket. :)

wareya and others added 28 commits November 18, 2020 13:14
Set components to link against the float64 variants of bullet when the above value is turned on.
…we only want -float64 suffixes for Debian-likes.
@Capostrophic
Copy link
Collaborator

Capostrophic commented Dec 27, 2020

GitLab counterpart of this PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants