Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Container base record mutations #3001

Closed
wants to merge 35 commits into from

Conversation

Assumeru
Copy link
Contributor

@Assumeru Assumeru commented Sep 3, 2020

@Assumeru
Copy link
Contributor Author

Assumeru commented Sep 13, 2020

So it turns out scripted items in containers have been broken since they were initially implemented. The scripts don't start running till the container is opened.

Features be creeping.

Edit: Or not. Vanilla doesn't run them after saving and reloading.

@psi29a
Copy link
Member

psi29a commented Sep 17, 2020

/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp: In member function ‘virtual void MWScript::Container::OpAddItem<R>::execute(Interpreter::Runtime&)’:
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp:71:69: error: ‘const class MWWorld::Class’ has no member named ‘getContainerStore’
   71 |                     MWWorld::ContainerStore& store = ptr.getClass().getContainerStore (ptr);
      |                                                                     ^~~~~~~~~~~~~~~~~
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp: In member function ‘virtual void MWScript::Container::OpGetItemCount<R>::execute(Interpreter::Runtime&)’:
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp:134:69: error: ‘const class MWWorld::Class’ has no member named ‘getContainerStore’
  134 |                     MWWorld::ContainerStore& store = ptr.getClass().getContainerStore (ptr);
      |                                                                     ^~~~~~~~~~~~~~~~~
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp: In member function ‘virtual void MWScript::Container::OpRemoveItem<R>::execute(Interpreter::Runtime&)’:
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp:169:69: error: ‘const class MWWorld::Class’ has no member named ‘getContainerStore’
  169 |                     MWWorld::ContainerStore& store = ptr.getClass().getContainerStore(ptr);
      |                                                                     ^~~~~~~~~~~~~~~~~
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp: In member function ‘virtual void MWScript::Container::OpEquip<R>::execute(Interpreter::Runtime&)’:
/home/travis/build/OpenMW/openmw/apps/openmw/mwscript/containerextensions.cpp:238:45: error: ‘const class MWWorld::Class’ has no member named ‘getContainerStore’
  238 |                         it = ptr.getClass().getContainerStore (ptr).add (item, 1, ptr);
      |                                             ^~~~~~~~~~~~~~~~~

@Assumeru
Copy link
Contributor Author

Assumeru commented Sep 17, 2020

Oh yeah, that's just my note-to-self-fix-this-stuff 😃

Note to self: fix memory leak below

@Assumeru Assumeru changed the title [WIP] Containers [WIP] Container base records Sep 20, 2020
@Assumeru Assumeru changed the title [WIP] Container base records [WIP] Container base record mutations Sep 20, 2020
@Assumeru
Copy link
Contributor Author

@Assumeru Assumeru closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants