PHP 8.1

[luigifab]

I tried PHP 8.1.0-beta3 (provided by deb.sury.org).

There is a "bad" change: Deprecated functionality: trim(): Passing null to parameter #1 ($string) of type string is deprecated in app/code/core/Mage/Core/Model/Config.php on line 1278

<?php
echo PHP_VERSION,"\n";
error_reporting(E_ALL);
ini_set('display_errors', 1);

echo strlen(null);

[kiatng]

magento-lts/app/code/core/Mage/Core/Model/Config.php

Lines 1274 to 1292 in 4885b20

	$className = null;
	if (isset($config->rewrite->$class)) {
	$className = (string)$config->rewrite->$class;
	} else {
	/**
	* Backwards compatibility for pre-MMDB extensions.
	* In MMDB release resource nodes <..._mysql4> were renamed to <..._resource>. So <deprecatedNode> is left
	* to keep name of previously used nodes, that still may be used by non-updated extensions.
	*/
	if (isset($config->deprecatedNode)) {
	$deprecatedNode = $config->deprecatedNode;
	$configOld = $this->_xml->global->{$groupType.'s'}->$deprecatedNode;
	if (isset($configOld->rewrite->$class)) {
	$className = (string) $configOld->rewrite->$class;
	}
	}
	}
	$className = trim($className);

An easy fix is change line 1274 to $className = ''.

[luigifab]

Yes, but there are a lot of errors like this.
I copy past the first.
I'm sad.

[ADDISON74]

If we manage to check the changes brought by each new PHP version, I don't think there will be any issues (at least not many). It's true that OpenMage has a lot of shards inside that have accumulated over time but most of it has been solved.

[ADDISON74]

I did a search for the error an look what I found:

https://php.watch/versions/8.1/internal-func-non-nullable-null-deprecation

Most likely in the OpenMage code there are other variables that have assigned null.

[ADDISON74]

And here is the list of all information about 8.1

https://php.watch/versions/8.1

[Flyingmana]

looks like we will have the same again as with 8.0, there we already hat a set of similar issues related to strong typing

[kiatng]

Have anyone checkout https://github.com/Shardj/zf1-future, seems quite active, and the community is updating to PHP8:

Over 200 updates and bug fixes since 1.12!
The ZF1 community has been hard at work updating Zend Framework with all of the latest features of PHP 7 and 8.0.

If there is a way to port and merge it into OM, it'll make OM lives longer.

[luigifab]

I will try it!