Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when saving product with image without description #4023

Closed
MateusM3 opened this issue May 31, 2024 · 6 comments · Fixed by #4024
Closed

Error when saving product with image without description #4023

MateusM3 opened this issue May 31, 2024 · 6 comments · Fixed by #4024
Labels

Comments

@MateusM3
Copy link

MateusM3 commented May 31, 2024

Preconditions (*)

  1. OpenMage 20.8.0
  2. PHP 8.2

Steps to reproduce (*)

  1. Open the Catalog -> Create Product -> Upload Images -> with out description (label) -> Save

Expected result (*)

  1. Saving the product with an empty label like previous versions, may be the version of PHP that is more careful regarding the array key not existing

Actual result (*)

error-img-default

@fballiano
Copy link
Contributor

@MateusM3 can you test #4024?

@MateusM3
Copy link
Author

MateusM3 commented Jun 3, 2024

Thaks @fballiano ! But Its was partially corrected, still with the error on line 170, I corrected it as follows, taking your correction as an example
image

Can you update your Pull request with this correction too?

@kiatng
Copy link
Contributor

kiatng commented Jun 4, 2024

I cannot reproduce the error on ver21 beta2.

On 20.8, I have

Warning: Undefined array key "label_use_default" in .../app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Media.php on line 250

@fballiano
Copy link
Contributor

@kiatng on v21 I see the same error, did you enable developer mode there too?

@fballiano
Copy link
Contributor

@MateusM3 how do you trigger the error you see on line 170? I can't reproduce it with my patch #4024

@MateusM3
Copy link
Author

MateusM3 commented Jun 5, 2024

@fballiano I tested it here and it worked, thank you!
Would it be possible to release a version 20.9.1 with this fix? I wanted to update here about having to overwrite the class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants