Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing meta tags to prevent SUPEE-11295 warnings #1236

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Adds missing meta tags to prevent SUPEE-11295 warnings #1236

merged 1 commit into from
Oct 18, 2020

Conversation

wilfriedwolf
Copy link
Contributor

@wilfriedwolf wilfriedwolf commented Sep 29, 2020 •
edited

Description (*)

Magereport.com checks for <meta name="robots" ...> Tags in the changed files, to detect presence of SUPEE-11295

Related Pull Requests

none

Fixed Issues (if relevant)

  1. Fixes Magereport Check fails for SUPEE-11295 when using OpenMage-Admin-Theme #1235

Manual testing scenarios (*)

Just test with Magereprot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Template : admin Relates to admin template labels Sep 29, 2020
@aterjung aterjung self-requested a review September 29, 2020 08:19
aterjung
aterjung approved these changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@aterjung aterjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good finding, this must be lost while merging the different source themes, thank you!

@colinmollenhour
Copy link
Member

Thanks for the PR!

kkrieger85
kkrieger85 approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this

@kkrieger85 kkrieger85 merged commit c0c5342 into OpenMage:1.9.4.x Oct 18, 2020
@sreichel sreichel added this to the Release 19.4.8 / 20.0.4 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@aterjung aterjung aterjung approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml hacktoberfest-accepted Template : admin Relates to admin template
Projects
None yet
Milestone
Release 19.4.8 / 20.0.4
Development

Successfully merging this pull request may close these issues.

Magereport Check fails for SUPEE-11295 when using OpenMage-Admin-Theme
5 participants
@wilfriedwolf @colinmollenhour @aterjung @kkrieger85 @sreichel