Add some specific debugging hint to email queue recipient empty #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea what works best. Ideally I would want to log ID/SUBJECT/STORE so I know where to start looking if this happens. If you propose otherwise, then please adjust the pull request directly and push. Only small win here is a little more specific debugging. https://stackoverflow.com/questions/53581543/exception-mage-core-exception-with-message-message-recipients-data-must-be-se
kiatng
reviewed
Jan 11, 2021
|
In this case the ID and subject exist. The method checks for empty
recipients ... which is a good thing to do ... bt if it occurs you would
want to know "which" message entity has this problem
In this (rare) case we had 1 data row in queue but not corresponding data
in the linked recipients table
…On Mon, Jan 11, 2021 at 2:27 AM Ng Kiat Siong ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/code/core/Mage/Core/Model/Email/Queue.php
<#1386 (comment)>:
> @@ -96,7 +96,8 @@ protected function _afterSave()
protected function _beforeSave()
{
if (empty($this->_recipients) || !is_array($this->_recipients)) {
- Mage::throwException(Mage::helper('core')->__('Message recipients data must be set.'));
+ $error = Mage::helper('core')->__('Message recipients data must be set.');
+ Mage::throwException($error . " Msg Id:" . $this->getId());
Were you able to get the ID? I got a feeling that it's probably null.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1386 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7I26EV7HHUYSZLEMX3MLSZJHWVANCNFSM4V4REL7A>
.
|
kiatng
previously approved these changes
Jan 16, 2021
|
I fixed conflicts and slightly changed the message so that doesn't create a problem with translations. I think this can be merged. |
fballiano
approved these changes
Jan 13, 2023
ADDISON74
approved these changes
Jan 13, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 13, 2023
|
merged and cherrypicked to v20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea what works best. Ideally I would want to log ID/SUBJECT/STORE so I know where to start looking if this happens. If you propose otherwise, then please adjust the pull request directly and push. Only small win here is a little more specific debugging.
https://stackoverflow.com/questions/53581543/exception-mage-core-exception-with-message-message-recipients-data-must-be-se
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)