Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last login date in wrong in backend #1604

Closed
wants to merge 1 commit into from

Conversation

fballiano
Copy link
Contributor

In "adminhtml -> customers -> manage customers" if you click on a customer sheet and check the "last login" section, sometimes you get a weird situation like this:

Schermata 2021-05-07 alle 12 32 07

the "login date" for the store timezone is correct while the UTC one is not, that is because, in the code, the formatDate function expects a "date", not a "timestamp".

After the patch, this is the result:
Schermata 2021-05-07 alle 12 54 57

Manual testing scenarios (*)

Insert "2021-05-07 07:12:18" as "login_at" column in the "log_customer" table, for the user you want to test.

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label May 7, 2021
@ADDISON74
Copy link
Collaborator

ADDISON74 commented May 7, 2021

I guess there is another commit that fixes this issue. Please check it here #1525.

Kiatng approach seems to be much better using $useTimezone = true then UTC.

@fballiano
Copy link
Contributor Author

🤦🏻‍♂️ i hope it would have been merged...

anyways, the usetimezone = false should be exactly utc, but anyways this doesn't make sense.

@fballiano fballiano closed this May 7, 2021
@fballiano fballiano deleted the fix_last_login_date branch August 12, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants