Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to cancel orders like registerCancellation #1804

Merged
merged 1 commit into from May 30, 2022

Conversation

luigifab
Copy link
Collaborator

@luigifab luigifab commented Sep 3, 2021

Description

This little change allow user to cancel order with a comment.

Manual testing scenarios

For example:

$order->registerCancellation('Message')->save();
$order->cancel('Message')->save();

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Sep 3, 2021
@fballiano fballiano merged commit fcfe0bb into OpenMage:1.9.4.x May 30, 2022
@github-actions
Copy link

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  +1  5 ✔️ +1  2 💤 ±0  0 ❌ ±0 

Results for commit fcfe0bb. ± Comparison against base commit 4885b20.

@luigifab luigifab deleted the cancelOrderWithComment branch May 31, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants