Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Edit: Magento requests current password, even when you don't change it #198

Closed
wants to merge 1 commit into from
Closed

Account Edit: Magento requests current password, even when you don't change it #198

wants to merge 1 commit into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Mar 2, 2017

Just copied from https://magento.com/tech-resources/bug-tracking/issue/index/id/1525/

Steps to reproduce:
With the update to version 1.9.3.0 or 1.9.3.1 Magento displays the error message "Invalid current password" and don't save any changes when you try to edit your account data without setting a new password.

the problem is introduced in 1.9.3.0 and is caused by the fact that the password is always being validated even though the users has not checked the "Change password" combobox.

@cieslix
Copy link
Contributor

cieslix commented Mar 3, 2017

-1
IMHO this validation is fine like it is. If developer's intention was to check current password just for changing password this input would be hidden until marking checkbox "change password".

@sreichel
Copy link
Contributor Author

sreichel commented Mar 3, 2017

Agreed, but you got me wrong. ATM you'll get an "invalid password" message even when trying to edit some "non-password" account information. E.g you can't change your name cause of hidden pw request.

@cieslix
Copy link
Contributor

cieslix commented Mar 4, 2017

@sreichel IMHO to edit non-passwords account data from version 1.9.3.0 you have to provide current password too.

Magento CE 1.9.3.0 Release Notes, section Password enhancements

  • When a user changes their e-mail address, they are required to provide their password and to acknowledge the change from the previous address.

@sreichel
Copy link
Contributor Author

sreichel commented Mar 5, 2017

Custom template issue where PW input is hidden as long you dont want to change PW.

@sreichel sreichel closed this Mar 5, 2017
@sreichel sreichel deleted the hotfix/customer/controllers/account/editPostAction-invalid-password branch March 8, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants