Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpstan errors in pr1325 #2207

Merged
merged 1 commit into from Jun 9, 2022
Merged

Phpstan errors in pr1325 #2207

merged 1 commit into from Jun 9, 2022

Conversation

kiatng
Copy link
Collaborator

@kiatng kiatng commented Jun 9, 2022

Description (*)

Fixed 3 PHPStan errors:

  ------ ----------------------------------------------------------------- 
  Line   Catalog/Model/Category/Indexer/Product.php                       
 ------ ----------------------------------------------------------------- 
  199    Call to an undefined method Varien_Object::dataHasChangedFor().  
  200    Call to an undefined method Varien_Object::dataHasChangedFor().  
 ------ ----------------------------------------------------------------- 
 ------ ----------------------------------------------------------------- 
  Line   Catalog/Model/Resource/Product/Attribute/Backend/Urlkey.php      
 ------ ----------------------------------------------------------------- 
  66     Call to an undefined method Varien_Object::dataHasChangedFor().  
 ------ -----------------------------------------------------------------

Related Pull Requests

PR #1325.

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Cm/RedisSession Relates to Cm_RedisSession Component: Cms Relates to Mage_Cms Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Index Relates to Mage_Index Component: lib/Zend Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Newsletter Relates to Mage_Newsletter Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Persistant Relates to Mage_Persistant Component: ProductAlert Relates to Mage_ProductAlert Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Sendfriend Relates to Mage_Sendfriend labels Jun 9, 2022
@elidrissidev elidrissidev removed Component: Tag Relates to Mage_Tag Component: Wishlist Relates to Mage_Wishlist Component: Tax Relates to Mage_Tax Component: Shipping Relates to Mage_Shipping Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Persistant Relates to Mage_Persistant Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: Index Relates to Mage_Index Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: Sendfriend Relates to Mage_Sendfriend Component: Directory Relates to Mage_Directory Component: CatalogSearch Relates to Mage_CatalogSearch Template : install Relates to install template Component: Cm/RedisSession Relates to Cm_RedisSession Component: Rss Relates to Mage_Rss Component: lib/* Relates to lib/* translations Relates to app/locale JavaScript Relates to js/* XML Layout Template : default Relates to base template labels Jun 9, 2022
@elidrissidev
Copy link
Member

Don't know why some CI checks are missing 🧐

elidrissidev
elidrissidev approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@elidrissidev elidrissidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fballiano fballiano merged commit 90fb732 into OpenMage:20.0 Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  7 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 90fb732. ± Comparison against base commit f93c9e0.

@kiatng kiatng deleted the phpstan_errors_in_pr1325 branch February 27, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiatng @elidrissidev @fballiano