Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rewrite Varien_Image #2666

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Allow rewrite Varien_Image #2666

merged 4 commits into from
Jan 15, 2023

Conversation

luigifab
Copy link
Collaborator

Description

This PR allow to rewrite Varien_Image with config.xml.
I need these change for one of my module :).
See also #993.

<config>
 <global>
  <models>
   <varien>
    <rewrite>
     <image>Example_Example_Model_Example</image>
    </rewrite>
   </varien>
  </models>
 </global>
</config>

OpenMage 20.0.16 / PHP 8.2.0

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches labels Oct 20, 2022
@luigifab luigifab marked this pull request as ready for review November 6, 2022 12:07
fballiano
fballiano approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreichel
Copy link
Contributor

@fballiano i'll let you merge, for better overview what has to be cherry-picked for v20

@fballiano fballiano merged commit c493d43 into OpenMage:1.9.4.x Jan 15, 2023
fballiano pushed a commit that referenced this pull request Jan 15, 2023
@luigifab @fballiano
Allow rewrite Varien_Image (#2666)
cd3717a
@fballiano
Copy link
Contributor

merged and cherry picked to v20 with no conflicts

@luigifab luigifab deleted the new-varienimage branch January 15, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@sreichel sreichel sreichel approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luigifab @sreichel @fballiano @ADDISON74