Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use store data for products of order items #2723

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

luigifab
Copy link
Collaborator

@luigifab luigifab commented Nov 17, 2022

Description

This PR update products data of order items.
With it, we use products data from the store of the order, and not from "default".

In production since almost 2 years.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Nov 17, 2022
Copy link
Collaborator

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

public function getProduct()
{
$product = $this->_getData('product');
if ($product === null && $this->getProductId()) {
$product = Mage::getModel('catalog/product')
->setStoreId($this->getQuote()->getStoreId())
->load($this->getProductId());
$this->setProduct($product);
}

@fballiano fballiano merged commit 569dfe4 into OpenMage:1.9.4.x Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 569dfe4. ± Comparison against base commit 7f75489.

fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 2, 2022
@luigifab luigifab deleted the order-product branch December 2, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants