Use default paths for config files #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2022 03:09
# Conflicts: # phpstan.dist.baseline.neon
added 2 commits
November 30, 2022 06:06
- added badges - added links to workflows - shorter workflow names
sreichel
referenced
this pull request
Nov 30, 2022
* PHP-CS-Fixer fixes Signed-off-by: Sven Reichel <github-sr@hotmail.com> * Updated workflow Signed-off-by: Sven Reichel <github-sr@hotmail.com> * Added php-cs-fixer workflow Signed-off-by: Sven Reichel <github-sr@hotmail.com> * Added PHPCompatibility check * PHPCompatibility check can fail * Fixes: Node.js 12 actions are deprecated * Fixes: PSR12.ControlStructures.ControlStructureSpacing.LineIndent * Fixes: PSR12.ControlStructures.ControlStructureSpacing.CloseParenthesisLine * Dond check CM_Redis every time * Add .php-cs-fixer.cache to .gitignore * Fixes class name (wrong place ... i know) * Minor fixes * Combined workflows * Added app/Mage.php and files from root to rulesets * Remove unused phpstan_experimental_level.neon * Updated phpstan.neon (for upcoming commits) * Set PhpStan level to 5 (from 3) * Update phpstan to v1.9.2 * Updated phpstan-baseline.neon * Updated phpstan-baseline.neon * Update app/code/core/Mage/Tag/Model/Resource/Tag.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * Update lib/Varien/Db/Adapter/Pdo/Mysql.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> * Set workflow include paths (skip other files) * Updated labeler.yml * Removed travis label * Improved workflow (#26) * Fixed grep modifier to get correct count * Updated ECG sniff baseline * Added Mage_Centinal to PhpStan checks * Added Mage_PaypalUk to PhpStan checks * Update app/code/core/Mage/Paypal/Model/Config.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com> Signed-off-by: Sven Reichel <github-sr@hotmail.com> Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
|
I don't love the idea of all these new files in the main folder but I see your point |
|
I also like a "clean" root directory, but these files belong there, not to |
fballiano
previously approved these changes
Dec 1, 2022
ADDISON74
previously approved these changes
Dec 2, 2022
|
sadly there's a conflict now |
# Conflicts: # phpstan.dist.baseline.neon
fballiano
approved these changes
Dec 2, 2022
ADDISON74
approved these changes
Dec 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
(2nd last planed workflow update for next time)
I just moved config files for phpcs and other tools to their default paths (for being automatically detected).
.distfrom filename to use your configManual testing scenarios (*)
vendor/bin/phpstan analyze)Note: Using configuration file /***/phpstan.dist.neon.should show upContribution checklist (*)