Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DOCblocks (fixed param null) #2776

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Updated DOCblocks (fixed param null) #2776

merged 5 commits into from
Dec 7, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 2, 2022 •
edited
Loading

Description (*)

Fixed some docblocks. Marked unused params as deprecated. (mixed type will be fixed later.)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa labels Dec 2, 2022
@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Dec 2, 2022
sv3n and others added 2 commits December 3, 2022 21:04
@kiatng
Update app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php
42b7a8f 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel sreichel merged commit e73c237 into OpenMage:1.9.4.x Dec 7, 2022
@sreichel sreichel deleted the fix/phpdocs/param-null branch December 7, 2022 01:10
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 7, 2022
@sreichel @kiatng @fballiano
Updated DOCblocks (fixed param null) (OpenMage#2776)
dff1e2e 
* Just updated docs ...

* ... and updated phpstan baseline.

* Apply suggestions from code review

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

* Update app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@fballiano fballiano mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sreichel @fballiano @kiatng