Added helper for admin button onclick actions #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
sreichel
changed the title
|
The new methods return javascript code, so they should be suffixed with Js instead of Html |
luigifab
reviewed
Dec 8, 2022
| } | ||
|
|
||
| $message = Mage::helper('core')->jsQuoteEscape($message); | ||
| return "confirmSetLocation('{$message}', '{$url}')"; |
There was a problem hiding this comment.
Not same format as line 103 :)
There was a problem hiding this comment.
I've used the format as it was used before.
elidrissidev
approved these changes
Dec 25, 2022
ADDISON74
approved these changes
Dec 25, 2022
|
After creating a refund with HiPay, when we are going on the refund, we have:
Probably due to:
The error is auto fixed when HiPay send the notification: "Notification from Hipay: status: code-125 Message: Refunded amount: 17.48".
If I'm not wrong, there is only one usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added helper methods for admin buttons onclick code for ...
... to not add escaping slashes every time ... and fixed some whitespaces ...
Contribution checklist (*)