Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs for admin save base urls #2800

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Fixed bugs for admin save base urls #2800

merged 3 commits into from
Dec 22, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 10, 2022 •
edited
Loading

Description (*)

It is possible to save invalid secure/unsecure base URLs ...

  • you can save empty urls (leads to error)
    An error occurred while saving this configuration: Notice: Undefined index: host in /var/www/html/app/code/core/Mage/Core/Helper/Url.php on line 175
  • you can save urls with leading/trailing spaces
  • you can save urls with spaces

Manual testing scenarios (*)

  1. save empty base url (or js, media, ...)
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Core Relates to Mage_Core Component: Page Relates to Mage_Page translations Relates to app/locale labels Dec 10, 2022
@sreichel sreichel added the bug label Dec 10, 2022
@sreichel sreichel changed the title Fixed bugs for admin save an base urls Fixed bugs for admin save base urls Dec 11, 2022
@sreichel sreichel removed the translations Relates to app/locale label Dec 12, 2022
@fballiano fballiano merged commit 2cb8331 into OpenMage:1.9.4.x Dec 22, 2022
@sreichel sreichel deleted the fix/config-baseurl branch December 22, 2022 22:06
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 22, 2022
@sreichel @fballiano
Fixed bugs for adminhtml save base urls (OpenMage#2800)
7b95491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
bug Component: Adminhtml Relates to Mage_Adminhtml Component: Core Relates to Mage_Core Component: Page Relates to Mage_Page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sreichel @fballiano @ADDISON74