Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved null-byte fix from lib/Zend to lib/Magento #2807

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Moved null-byte fix from lib/Zend to lib/Magento #2807

merged 2 commits into from
Dec 13, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 12, 2022 •
edited
Loading

Description (*)

Magento fixed this in lib/Zend, that will be (hopefully) replaced soon. Moved this to lib/Magento, that is called before.

ZF1-future does not have this added for Mysql (yet?).

Edit: cast to string is also in ZF1F

Related Pull Requests

  1. See Some changes for compatibility with PHP 8.1 #1812
  2. See Replaced bundled Zend Framework with zf1-future #2787

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel added PHP 8.1 Related to PHP 8.1 Component: lib/Zend Component: lib/Magento Relates to lib/Magento and removed Component: lib/Zend Component: lib/* Relates to lib/* Component: lib/Magento Relates to lib/Magento labels Dec 12, 2022
@github-actions github-actions bot added the Component: lib/* Relates to lib/* label Dec 12, 2022
@sreichel sreichel changed the title Moved null-byte fix to lib/Magento Moved null-byte fix from lib/Zend to lib/Magento Dec 13, 2022
@fballiano fballiano merged commit 3bdeef5 into OpenMage:1.9.4.x Dec 13, 2022
@sreichel sreichel deleted the zend-clean branch December 13, 2022 20:54
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 14, 2022
@sreichel @fballiano
Moved null-byte fix from lib/Zend to lib/Magento (OpenMage#2807)
919ae04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: lib/Magento Relates to lib/Magento Component: lib/* Relates to lib/* PHP 8.1 Related to PHP 8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sreichel @fballiano @ADDISON74