Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Mage_PageCache #2813

Merged
merged 6 commits into from
Dec 23, 2022
Merged

Removed Mage_PageCache #2813

merged 6 commits into from
Dec 23, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 16, 2022

Description (*)

Mage_PageCache was removed for v20 only. Created composer module to keep functionality if needed.

Related Pull Requests

  1. See Removed module Mage_PageCache #2258

Can be reinstalled with composer require openmage/module-mage-pagecache:dev-master

Questions or comments

@fballiano should we add these modules to releasebuilder?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: PageCache Relates to Mage_PageCache documentation phpstan PHPStorm Template : admin Relates to admin template translations Relates to app/locale labels Dec 16, 2022
@fballiano
Copy link
Contributor

if we backport everything we should just merge v20 in v19 and call it a day ;-)

@sreichel
Copy link
Contributor Author

That would be to easy 😆

@fballiano
Copy link
Contributor

that is what i mean when i say to drop v19 in favour of v20

@github-actions github-actions bot added Template : base Relates to base template XML Layout labels Dec 17, 2022
@fballiano
Copy link
Contributor

I've created https://github.com/OpenMage/module-mage-pagecache for you ;-)

@sreichel
Copy link
Contributor Author

Pushed.

fballiano
fballiano previously approved these changes Dec 18, 2022
@fballiano
Copy link
Contributor

about adding it to the release builder, I wouldn't do that (my personal opinion) for these reason:

  • I wouldn't want it in v20
  • it is easy to install it
  • if people using the "built" zip file "overwrite" the core with the new versions (without deleting folders firts) they wouldn't even recognise that's gone (I know, that would be the same with CM modules but those are much more important in my opinion)

@fballiano fballiano merged commit 0ea19ee into OpenMage:1.9.4.x Dec 23, 2022
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 23, 2022
@sreichel sreichel deleted the phpstan/mage-page-cache branch December 23, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: PageCache Relates to Mage_PageCache documentation PHPStorm Template : admin Relates to admin template Template : base Relates to base template translations Relates to app/locale XML Layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants