Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirm dialog to critical massactions #2814

Merged
merged 4 commits into from
Dec 17, 2022
Merged

Add confirm dialog to critical massactions #2814

merged 4 commits into from
Dec 17, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 16, 2022

Description (*)

Added confirm dialog to some massactions.

I did not change it for every massaction, but added a default check by massaction id/name.

    protected static $needsConfirm = [
        self::CANCEL_ORDER,
        self::HOLD_ORDER,
        self::UNHOLD_ORDER,
        self::DELETE,
        self::REMOVE
    ];

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Some mass actions in Orders grid don't have a confirmation dialog #2323

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Index Relates to Mage_Index labels Dec 16, 2022
@sreichel sreichel changed the title Add confirm to critical massactions Add confirm dialog to critical massactions Dec 17, 2022
@fballiano
Copy link
Contributor

quickly tested, seems to be working fine

@fballiano fballiano merged commit f51ab22 into OpenMage:1.9.4.x Dec 17, 2022
@sreichel sreichel deleted the massactions branch December 17, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Index Relates to Mage_Index phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some mass actions in Orders grid don't have a confirmation dialog
3 participants