Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notes about composer library/modules to README (for 19.5.x and 20.1.x) #2851

Merged
merged 8 commits into from
Dec 26, 2022

Conversation

fballiano
Copy link
Contributor

In #2411 and #2827 we radically changed the structure of OM, which was in place since the beginning of the project. So it's important that we update our documentation explaining the changes and the upgrade process.

Suggestions are welcome!

sreichel
sreichel previously approved these changes Dec 25, 2022
@ADDISON74
Copy link
Contributor

I would analyze the behavior of two types of users who do not use Composer for various reasons. Those who download OM for the first time to evaluate it and those who want to upgrade from Magento or a previous versions of OM.

For the first type of users, those who will only download the archive of the repository will have to manually add all those libraries that we removed this year. They must find their list in the documentation, I would even give them the proper links. Basically I am addressing novice users and not advanced ones

For the second type of users, first of all, they must bring their version in correlation with what is now in the repository and then manually add the libraries. Here the situation should be better evaluated in case it is necessary to delete some files and directories, if it does not do an upgrade. For example, you rightly mentioned that you have to delete /lib/Zend and then add ZF1-Future.

In conclusion, do we cover with these specifications all the situations that may arise?

README.md Outdated Show resolved Hide resolved
@fballiano
Copy link
Contributor Author

@ADDISON74 there's no need (for any of the 2 types of users) to manually have to download the libraries, the release builder adds them already ;-) So I think we should already be covering the 2 different use cases.

sreichel
sreichel previously approved these changes Dec 26, 2022
@sreichel sreichel merged commit 1e64210 into OpenMage:1.9.4.x Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants