Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #2874 #2878

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Fix for #2874 #2878

merged 1 commit into from
Jan 1, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 1, 2023 •
edited

Description (*)

Fix for passing null as first argument in 3rd-party-code.

Mage_Adminhtml_Block_Widget_Grid_Massaction_Abstract->addItem(NULL, Array)

Fixed Issues (if relevant)

  1. Fixes Merged PR #2814 is causing trouble with the MageWorx Advanced Product Options extension #2874

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel added the 3rd-party Related to 3rd-party code or issues with customization label Jan 1, 2023
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jan 1, 2023
ADDISON74
ADDISON74 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Collaborator

@ADDISON74 ADDISON74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this PR fixes the reported issue.

@fballiano fballiano merged commit e29f7c5 into 1.9.4.x Jan 1, 2023
@fballiano fballiano deleted the fix/2874 branch January 1, 2023 20:20
fballiano pushed a commit to fballiano/openmage that referenced this pull request Jan 2, 2023
@sreichel @fballiano
Fixed "must be of type string, null given" ref OpenMage#2874 (OpenMag…
1c99281 
…e#2878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
3rd-party Related to 3rd-party code or issues with customization Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merged PR #2814 is causing trouble with the MageWorx Advanced Product Options extension
3 participants
@sreichel @fballiano @ADDISON74