Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix searching for utf8 characters #2919

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix searching for utf8 characters #2919

merged 1 commit into from
Jan 11, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 11, 2023 •
edited

Description (*)

Fixed Issues (if relevant)

  1. Fixes searching for utf8 characters breaks product limiter #1114

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Template : base Relates to base template Template : rwd Relates to rwd template labels Jan 11, 2023
fballiano
fballiano approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering a few things, but this PR only changes the toolbar.phtml so it's perfectly fine!

ADDISON74
ADDISON74 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@ADDISON74 ADDISON74 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link is encoded twice. The two links in the description explain the issue very well.

@fballiano fballiano merged commit eddf020 into OpenMage:1.9.4.x Jan 11, 2023
fballiano pushed a commit that referenced this pull request Jan 11, 2023
@fballiano
Fixed "searching for utf8 characters breaks product limiter", ref #1114…
f420b9c 
… (#2919)
@fballiano
Copy link
Contributor

cherry-picked to v20 with no conflicts

@sreichel sreichel deleted the fix-1114 branch January 11, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
bug confirmed Component: Catalog Relates to Mage_Catalog Template : base Relates to base template Template : rwd Relates to rwd template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

searching for utf8 characters breaks product limiter
3 participants
@sreichel @fballiano @ADDISON74