Replace strftime with date #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: CatalogIndex
sreichel
previously requested changes
Jan 14, 2023
sreichel
reviewed
Jan 14, 2023
| $this->setCreatedAt(strftime('%Y-%m-%d %H:%M:%S', time())); | ||
| $this->setScheduledAt(strftime('%Y-%m-%d %H:%M', (int)$time)); | ||
| $this->setCreatedAt(date(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT)); | ||
| $this->setScheduledAt(date('Y-m-d H:i:00', (int)$time)); |
There was a problem hiding this comment.
Suggested change
| $this->setScheduledAt(date('Y-m-d H:i:00', (int)$time)); | |
| $this->setScheduledAt(date('Y-m-d H:i', (int)$time)); |
There was a problem hiding this comment.
This is strange to put a value without seconds for me, even if this works.
php > echo date('Y-m-d H:i');
2023-01-14 20:49
php > echo date('Y-m-d H:i:00');
2023-01-14 20:49:00
There was a problem hiding this comment.
I just compared before/after and this is the only change i found in output. (y, its strange ;) )
There was a problem hiding this comment.
Do you agree to keep current behavior?
There was a problem hiding this comment.
Either way both will save the value with 00 seconds
There was a problem hiding this comment.
I don't have an opinion on this so as you all prefer :-)
|
Any chance you could also include |
|
This is another story. |
sreichel
approved these changes
Jan 16, 2023
elidrissidev
approved these changes
Jan 16, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 16, 2023
|
merged and cherrypicked to v20 |
justinbeaty
pushed a commit
to justinbeaty/magento-lts
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replace
strftimebecause it is deprecated since PHP 8.1. Ref #1812.Hope it's good 馃馃徑.
Partially tested with PHP 7.2, 7.3, 7.4, 8.0, 8.1, 8.2 with OpenMage 20.0.18.
Contribution checklist