PHP8.0 Fixes passing null as 1st parameter to mktime() #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreichel
changed the title
luigifab
approved these changes
Jan 15, 2023
There was a problem hiding this comment.
With phpx.x -a and echo mktime(null, null, null, 1),' ',mktime(0, null, null, 1);
I have:
- php7.2:
1673737200 1673737200 - php7.3:
1673737200 1673737200 - php7.4:
1673737200 1673737200 - php8.0:
1673739363 1673739363 - php8.1:
1673739364 1673739364 - php8.2:
1673742965 1673742965
ADDISON74
approved these changes
Jan 15, 2023
elidrissidev
approved these changes
Jan 15, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 15, 2023
|
cherrypicked to v20 with no conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues (if relevant)
Deprecated functionality: mktime(): Passing null to parameter #1 ($hour) of type int is deprecatedManual testing scenarios (*)
Questions or comments
Contribution checklist (*)