Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix less than typo #2952

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

justinbeaty
Copy link
Contributor

@justinbeaty justinbeaty commented Jan 16, 2023

Description (*)

Fixed "less then" -> "less than" typo. Maybe it should actually be "must be less than or equal to %s symbols" though.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the translations Relates to app/locale label Jan 16, 2023
@justinbeaty
Copy link
Contributor Author

The two places I see this used are in attribute code and customer group name. Both allow the exact maximum length characters, so "less than or equal to" would be correct, although more verbose.

@fballiano fballiano merged commit 7c16d61 into OpenMage:1.9.4.x Jan 16, 2023
fballiano pushed a commit that referenced this pull request Jan 16, 2023
@fballiano
Copy link
Contributor

merged and cherrypicked to v20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Relates to app/locale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants