Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ascending sort for themes/packages dropdown #2967

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Ascending sort for themes/packages dropdown #2967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6ff482
Ascending sort themes/packages dropdown lists in Backend
sreichel Jan 18, 2023
fd01d93
phpstan.dist.baseline.neon
sreichel Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/code/core/Mage/Core/Model/Design/Source/Design.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,15 @@ public function getAllOptions($withEmpty = true)
'value' => $package . '/' . $theme
];
}
asort($themeOptions);
$packageOption['value'] = $themeOptions;
$options[] = $packageOption;
}
$this->_options = $options;
}
$options = $this->_options;
asort($options);

if ($withEmpty) {
array_unshift($options, [
'value' => '',
Expand Down
5 changes: 5 additions & 0 deletions phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6710,6 +6710,11 @@ parameters:
count: 1
path: app/code/core/Mage/Shipping/Model/Tracking/Result.php

-
message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#"
count: 1
path: app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php

-
message: "#^Method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addPopularity\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#"
count: 1
Expand Down