Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ifconfig for layout updates #2974

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Add ifconfig for layout updates #2974

merged 1 commit into from
Jan 19, 2023

Conversation

luigifab
Copy link
Collaborator

Description

This PR add the possibility to update handle with ifconfig, like for action.

<something>
    <update handle="someone" ifconfig="x/y/z" />
</something>

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Jan 19, 2023
fballiano
fballiano approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly it was part of some module but LGTM and it's a good addition

@fballiano fballiano merged commit 91bde74 into OpenMage:1.9.4.x Jan 19, 2023
fballiano pushed a commit that referenced this pull request Jan 19, 2023
@luigifab @fballiano
Added support for "ifconfig" for layout updates (#2974)
dee4855
@fballiano
Copy link
Contributor

merged and v20ed

@luigifab luigifab deleted the update-ifconfig branch January 19, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luigifab @fballiano @sreichel