Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version check from api.php, get.php, index.php, install.php #2986

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

justinbeaty
Copy link
Contributor

Description (*)

Composer autoloader already checks PHP versions, and we will build new releases with the release builder. So, the version check is not needed. See related pull request for more info.

Related Pull Requests

#2982

Questions or comments

We need to bump the minimum supported version to 7.4.0

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@fballiano fballiano merged commit 38d1486 into OpenMage:1.9.4.x Jan 20, 2023
@fballiano
Copy link
Contributor

merged and v20ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants