Bugfixes addto.phtml #3002
Merged
Bugfixes addto.phtml #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several issues: The separator is printed when not needed, code is executed when not needed, and the `<ul>` is printed when not needed.
github-actions
bot
added
Component: Catalog
kiatng
reviewed
Jan 30, 2023
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Outdated
Show resolved
Hide resolved
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Outdated
Show resolved
Hide resolved
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Outdated
Show resolved
Hide resolved
…addto.phtml Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
…addto.phtml Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
fballiano
reviewed
Jan 31, 2023
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Show resolved
Hide resolved
fballiano
reviewed
Jan 31, 2023
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Show resolved
Hide resolved
fballiano
reviewed
Jan 31, 2023
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Outdated
Show resolved
Hide resolved
fballiano
reviewed
Jan 31, 2023
app/design/frontend/rwd/default/template/catalog/product/view/addto.phtml
Outdated
Show resolved
Hide resolved
fballiano
approved these changes
Jan 31, 2023
fballiano
pushed a commit
that referenced
this pull request
Feb 1, 2023
|
merged and v20ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several issues: The separator is printed when not needed, code is executed when not needed, and the
<ul>is printed when not needed.